Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Y-axis label missing in the analysis page. #883

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix Y-axis label missing in the analysis page. #883

merged 3 commits into from
Mar 11, 2024

Conversation

rajdangol0077
Copy link
Contributor

@rajdangol0077 rajdangol0077 commented Mar 8, 2024 •
edited by j08lue
Loading

Fixes #877

@netlify Netlify
Copy link

netlify bot commented Mar 8, 2024 •
edited
Loading

✅ Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 61af758
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/65ebb84d6f2b1200082548e2
😎 Deploy Preview https://deploy-preview-883--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rajdangol0077 rajdangol0077 linked an issue Mar 8, 2024 that may be closed by this pull request
[Analysis] Y-axis label missing (again) #877
Closed
1 task
@slesaad slesaad requested a review from sandrahoang686 March 8, 2024 19:29
@slesaad
Copy link
Member

slesaad commented Mar 8, 2024

@rajdangol0077 i see that there's still some issues, look at the attached images (datasets: NO2 PT and NPP)
image - the label and values are overlapping
image - the superscript 2 is cutoff a bit

Can you see if you can fix those too?

@rajdangol0077
Copy link
Contributor Author

@slesaad I could only fix this by adding width and offset to the axis and labels. Do verify and let me know if I need to make other changes.

sandrahoang686
sandrahoang686 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually validated analysis page results. lgtm!

@slesaad slesaad merged commit 3e3734a into main Mar 11, 2024
8 checks passed
@slesaad slesaad deleted the fix/analysis-y-label branch March 11, 2024 16:54
@slesaad slesaad mentioned this pull request Mar 11, 2024
Merged
@sandrahoang686 sandrahoang686 mentioned this pull request Mar 19, 2024
Merged
1 task
@hanbyul-here hanbyul-here mentioned this pull request Mar 21, 2024
Merged
hanbyul-here added a commit that referenced this pull request Mar 25, 2024
@hanbyul-here
Cut a release for 4.2.0 (#895)
d78db82 
## 🎉 Features
- Optional media attributes for layers:
#843
- Add custom javascript injection
#846
- ADR for V2 Refactor: #875

## 🚀 Improvements
- E&A imporvement. Related tickets
  - Layer select modal: #845
- Connect dataset information on layer:
#821
  - Layer info modal: #849
- Update data layer card:
#851
  - Hidden layers: #867
- Fast follow-ups: #851 ,
#862,
#863,
#860
  - PR template: #880


## 🐛 Fixes
- Return datasets even when there is a dataset without summaries:
#786
- Show all the datasets on Data Catalog page:
#837
- Block Map user defined position fix:
#784
- Geocoder centering on various projecctions:
#826
- Wording, typo: #869
#854,
#874,
- Fix yaxis labeling: #883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrahoang686 sandrahoang686 sandrahoang686 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Analysis] Y-axis label missing (again)
3 participants
@rajdangol0077 @slesaad @sandrahoang686